Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Spec for opcode EXTCODESIZE#341

Merged
icemelon merged 6 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/opcode-extcodesize
Dec 15, 2022
Merged

Spec for opcode EXTCODESIZE#341
icemelon merged 6 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/opcode-extcodesize

Conversation

@silathdiir

Copy link
Copy Markdown
Contributor

Close #327

It is similar as EXTCODEHASH and BALANCE (used exists witness value).

@han0110 han0110 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look good to me! Only some part might be missing accidentally.

Comment thread src/zkevm_specs/evm/execution/extcodesize.py
Comment thread src/zkevm_specs/evm/execution/extcodesize.py
@silathdiir silathdiir requested a review from han0110 December 15, 2022 01:22

@han0110 han0110 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing all comments.

@ChihChengLiang

Copy link
Copy Markdown
Collaborator

Hi @icemelon, can you assign a reviewer for this PR?

@icemelon icemelon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement opcode EXTCODESIZE in Spec

4 participants